Review and publishing

When a task’s development is finished and a pull request is open, the task goes to review.

• Changes — diffs by module.
• Findings — review comments.
• Decision — approve or send back for rework.
• Publishing — a pull request upstream.

What has been checked

The review screen opens not with a diff but with what the pipeline has already checked for this task:

• Build — whether it passed in the task’s own environment, the exit code and how long it took;
• Tests — whether the make test regression run passed on the task branch, how many runs there were and the longest of them;
• Test inventory — how many tests there were on the main branch and how many there are on the task branch, how many are new and how many were switched back on;
• Findings — how many are open and how many dismissed, with a link to the panel.

The tests have a “Run log” — it opens the full output of the test run, step by step, including the output of make test. It is not a retelling or a summary: it is what actually ran — by code, not by the model.